codecov[bot]
commented
1 month ago Codecov Report
Attention: Patch coverage is 94.64286% with 6 lines in your changes missing coverage. Please review.
Project coverage is 83.54%. Comparing base (
2e06d00) to head (67ef015). Report is 1 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| orchestrator/graphql/loaders/subscriptions.py | 94.62% | 3 Missing and 2 partials :warning: |
| orchestrator/graphql/schema.py | 85.71% | 0 Missing and 1 partial :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #745 +/- ## ========================================== + Coverage 83.43% 83.54% +0.10% ========================================== Files 188 189 +1 Lines 9287 9385 +98 Branches 1523 1540 +17 ========================================== + Hits 7749 7841 +92 - Misses 1274 1277 +3 - Partials 264 267 +3 ``` | [Flag](https://app.codecov.io/gh/workfloworchestrator/orchestrator-core/pull/745/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=workfloworchestrator) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/workfloworchestrator/orchestrator-core/pull/745/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=workfloworchestrator) | `83.54% <94.64%> (+0.10%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=workfloworchestrator#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Reduce DB queries performed in GQL resolver for subscriptions by 50%:
subscription.product(N+1)inUseBySubscriptions/dependsOnSubscriptionsquery the subscription ids through a dataloader (N+1)Other:
custom_context_getterparameter toregister_graphql()to allow defining a custom context in Orchestrator implementationsorchestrator.graphql.schema,get_contexthas been renamed todefault_context_getterBump version from 2.7.5 to 2.7.6rc1