Removed stack trace and fix build

workfloworchestrator / pydantic-forms

Define JSON scheme with pydantic so a frontend can generate forms with pydantic validators

Apache License 2.0

8 stars 0 forks source link

Removed stack trace and fix build #26

Closed github-actions[bot] closed 2 days ago

github-actions[bot] commented 6 days ago

We return a stack trace in the responses that is not needed and reveals some internals.

Actions:

[x] Remove stacktrace from FormException responses
[x] Update tests for newer pydantic versions (currently main would fail when re-running tests)
[x] Clean up some requirements: Some type packages didn't exists anymore
[ ] Test with a frontend

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.14%. Comparing base (9da00f1) to head (c4a8313).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #26 +/- ## ========================================== + Coverage 85.66% 90.14% +4.48% ========================================== Files 27 27 Lines 537 548 +11 Branches 74 54 -20 ========================================== + Hits 460 494 +34 + Misses 73 50 -23 Partials 4 4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

acidjunk commented 2 days ago

@pboers1988 : It's a bit difficult to test in our infra: can you let someone test it with the v1 forms: MigrationSummary? These aren't used in our Workflows yet. I don't think anything has changed but there are some subtle changes in the JSON schemes, seems depended on which pydantic versions are used. Feel free to bump/release (patch) when it works. 🙏

I will rebase my translation branch on top of main after that: I think the new translation branch will cause a minor version bump.