Closed lorddavidiii closed 2 years ago
It looks like another PR I merged earlier did some of the things this PR does #167. Do you still need this merge? Or does the current version fix this problem?
hm, this could have fixed this problem. But I just wanted to test and recognized, that the output of lscpu
changes a bit, it adds (6 instances)
to the l2_cache_size
, so it is still returned this as string
and not as int
. This was changed in util-linux
version 2.37, this is the relevant commit: https://github.com/util-linux/util-linux/commit/9dadd3e60c9f75bcf0e29f182ac6c53a4985bb98. But well this PR does not fix this anymore so I am going to close this.
This is a actual output of lscpu
from util-linux 2.38.1 on the same laptop
$ lscpu
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 39 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 12
On-line CPU(s) list: 0-11
Vendor ID: GenuineIntel
Model name: Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz
CPU family: 6
Model: 165
Thread(s) per core: 2
Core(s) per socket: 6
Socket(s): 1
Stepping: 2
CPU(s) scaling MHz: 27%
CPU max MHz: 5000.0000
CPU min MHz: 800.0000
BogoMIPS: 5202.65
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3
sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb invpcid_single ssbd ibrs ibpb stibp ibrs_enhanced tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms inv
pcid mpx rdseed adx smap clflushopt intel_pt xsaveopt xsavec xgetbv1 xsaves dtherm ida arat pln pts hwp hwp_notify hwp_act_window hwp_epp pku ospke md_clear flush_l1d arch_capabilities
Virtualization features:
Virtualization: VT-x
Caches (sum of all):
L1d: 192 KiB (6 instances)
L1i: 192 KiB (6 instances)
L2: 1.5 MiB (6 instances)
L3: 12 MiB (1 instance)
NUMA:
NUMA node(s): 1
NUMA node0 CPU(s): 0-11
Vulnerabilities:
Itlb multihit: KVM: Mitigation: VMX disabled
L1tf: Not affected
Mds: Not affected
Meltdown: Not affected
Mmio stale data: Vulnerable: Clear CPU buffers attempted, no microcode; SMT vulnerable
Retbleed: Mitigation; Enhanced IBRS
Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Spectre v2: Mitigation; Enhanced IBRS, IBPB conditional, RSB filling, PBRSB-eIBRS SW sequence
Srbds: Vulnerable: No microcode
Tsx async abort: Not affected
Thanks.
I noticed the (6 instances)
stuff yesterday. I'm kind of disappointing that the test suite didn't catch that. I'll have to make a new bug for that.
On my laptop,
cpuinfo
returns thel2_cache_size
not asint
but asstring
. Investigating this, I found two problems with_friendly_bytes_to_int()
:lscpu
uses [GMK]iB units on my laptop, which were not covered by_friendly_bytes_to_int()
yetThese two problems resulting in returning a string instead of an int. This PR tries to fix this.
And as an example, the output of
lscpu
from my laptop: