search

workingconcept / trigger-craft-plugin

Kick off static deployments from Craft CMS only when you need them.
MIT License
13 stars 4 forks source link

Missing "dev mode deploy" setting? #5

Closed FreekVR closed 4 years ago

FreekVR commented 4 years ago

Hi!

First of all, thanks so much for this plugin, this is exactly what we need for a project I'm working on!

I was testing the automatic deploy on content change feature, and thought it wasn't working, until I found a reference in code if ($this->getSettings()->active && (! $isDevMode || $this->getSettings()->devModeDeploy))

So it seems it's not running on dev mode, which seems sensible, but it IS referencing a plugin setting I can't find anywhere, perhaps an unimplemented feature?

Regardless, perhaps it would help to add the setting, or otherwise a small remark in the readme, just in case someone else runs into the same problem.

mattstein commented 4 years ago

Hi @FreekVR, glad this plugin’s been useful!

The devModeDeploy setting exists and works, it’s just not exposed in the control panel UI and false by default.

The assumption is that anyone testing this locally would only be a developer doing so temporarily, so the setting is there just for convenience—if you create config/trigger.php you can change it there:

<?php

return [
    'devModeDeploy' => true
];
FreekVR commented 4 years ago

Ah thanks, that makes a bit more sense then :)