search

workmanw / ember-diff-attrs

An ember-addon that provides a dry way to track component attribute changes using lifecycle hooks.
MIT License
27 stars 6 forks source link

Upgrade ember weakmap to 3.0 #6

Closed ryanto closed 7 years ago

ryanto commented 7 years ago

WeakMap is now on the Ember object. See here: https://github.com/thoov/ember-weakmap#usage

workmanw commented 7 years ago

@ryanto Isn't this just in time for everyone to stop using the Ember namespace? Hehe. I'm actually wonder polyfills will looks like in the future where no one uses the Ember namespace.

ryanto commented 7 years ago

No idea! Reason for this PR is it clashes with ember macro helpers, which other addons like ember moment depend on.

https://github.com/kellyselden/ember-macro-helpers/blob/master/package.json#L26

@thoov do you have any input?

workmanw commented 7 years ago

@ryanto Well I have no objection to this, it was more of a curiosity.

thoov commented 7 years ago

@workmanw @ryanto I had the same question about the namespacing concern which I brought up with here: https://github.com/stefanpenner/ember-state-services/pull/76. You can read what Robert said but the TLDR is that it is still TBD. This is one area I will be looking into over the next few weeks as to what should be the correct way of import polyfills in this new import world we live in.

workmanw commented 7 years ago

@thoov 👍 thanks for providing that. I maintain a polyfill also, so it was more of curiosity for me than for this addon consuming another.