search

worknenjoy / gitpay

Bounties for issues on demand. Be rewarded by learning, using Git workflow and continuous integration
http://gitpay.me
Other
180 stars 160 forks source link

Fix Lint issues #1038

Closed alexanmtz closed 2 weeks ago

alexanmtz commented 5 months ago

When you do a push you will see many lint errors, and we need all those fixes so we can have the push hook green

alexanmtz commented 5 months ago

@KenjxJJ can you work on this?

KenjxJJ commented 5 months ago

Yes.

effaf commented 4 months ago

Hi @alexanmtz , I would like to work on this if there is no resolution yet.

alexanmtz commented 4 months ago

Hello @effaf , there's no resolution yet; feel free to work on it.

effaf commented 4 months ago

Hi @alexanmtz , thank you for assigning the issue. I have a few questions before I get started on this. 1) I ran the command npx eslint --fix ., and could see 104 errors. A lot of these errors were parsing errors due to older eslint version. Can I change the ecmaVersion in the configuration file? 2) Do you want me to comment out the console.log or delete it? 3) A lot of libraries have been imported but not used. Would the maintainers prefer deleting the code or commenting it out?

alexanmtz commented 4 months ago

Hi @alexanmtz , thank you for assigning the issue. I have a few questions before I get started on this.

  1. I ran the command npx eslint --fix ., and could see 104 errors. A lot of these errors were parsing errors due to older eslint version. Can I change the ecmaVersion in the configuration file?
  2. Do you want me to comment out the console.log or delete it?
  3. A lot of libraries have been imported but not used. Would the maintainers prefer deleting the code or commenting it out?

Hey, @effaf, thanks for jumping into this issue and your proactivity. You can change the ecmaVersion in the configuration, and we can eliminate all console.logs except the one with the comment // eslint-disable-next-line no-console

And we can remove the unused libraries.

alexanmtz commented 1 month ago

Hey @effaf, some progress on this one?

alexanmtz commented 4 weeks ago

There's a bounty of $20 for this one: https://gitpay.me/#/task/840

guvitorino commented 3 weeks ago

There's a bounty of $20 for this one: https://gitpay.me/#/task/840

I started working on this issue. I saw the comments above and will take them into consideration

alexanmtz commented 3 weeks ago

That's great @guvitorino, looking forward to review your solution and feel free to change the configuration as suggested before

and fix automatically some issues with npm run lint-fix

Anshgrover23 commented 3 weeks ago

hi i am also doing this

Anshgrover23 commented 3 weeks ago

/attempted Fix Lint issues #1038, plss check @alexanmtz also there is some parsing error were not resolving can u plss check

Anshgrover23 commented 3 weeks ago

/claim #1038

CodeWithInferno commented 3 weeks ago

/claim #1038

alexanmtz commented 3 weeks ago

Hello @Anshgrover23 , thanks for sending the PR, I will review in the weekend and when it's merged you can claim the bounty on the web page by going in "Solve issue" and pasting your PR when is merged in "Send Solution" tab

alexanmtz commented 3 weeks ago

Hey @guvitorino, we have already a PR to review for this one, so let's find another issue for you :)

Anshgrover23 commented 3 weeks ago

@alexanmtz thanks buddy, waiting for your merge reply and thanks for giving me chance

Anshgrover23 commented 3 weeks ago

@alexanmtz made some more commit changes review the pr once again please sir.

Anshgrover23 commented 3 weeks ago

@alexanmtz solved the optonal chaining errors . check new commit

alexanmtz commented 2 weeks ago

Hey @raviteja83, you fixed this issue successfully; many thanks for the contribution 🚀

You can claim your bounty by visiting this issue on Gitpay: https://gitpay.me/#/profile/task/840/fix-lint-issues

On "Solve Issue" and on the "Send Solution" tab, you can paste the PR merged and the Bounty process will be initiated I hope :)