worknenjoy / gitpay

Bounties for issues on demand. Be rewarded by learning, using Git workflow and continuous integration
http://gitpay.me
Other
180 stars 160 forks source link

Fix for Issue #1013 #1070

Closed webbdays closed 4 months ago

webbdays commented 4 months ago

Pull Request Template

supposed to Closes #1013 (not yet)

Description

To allow user to sort the columns in a table

Purpose

To allow user to sort the columns in a table

Solution

Using TableSortLabel component from MUI, Got to know about it after seeing the PR's related to this issue.

Screenshots

None

Checklist

Related Issues

None

Additional Notes

None

Contributor Guidelines

Fork the repo and create your branch from master. - done If you've added code that should be tested, add tests. - not yet If you've changed APIs, update the documentation. - NA Ensure the test suite passes. - tests on previous codebase are failing Make sure your code lints. - linting on previous codebase are failing Issue that pull request! - going to do it Check if the build is green before we start to review - waiting

Thank you.

webbdays commented 4 months ago

The problem with tests for previous code base is at Transfer.update() its not returning datavalues.

webbdays commented 4 months ago

I think hooks need to be setup like it was done for Task to store update history.

webbdays commented 4 months ago

tests pass for node v17.3.0

alexanmtz commented 4 months ago

Great @webbdays with the solution, I just changed the name of the component to make it more concise, but great job and well done with the build fix! 🎉

webbdays commented 4 months ago

Thank you.

webbdays commented 4 months ago

Thanks to PR's #1068 #1069 . Greatly helped.

webbdays commented 4 months ago

But tests for new functionality in frontend are not covered. And also code docs.

alexanmtz commented 4 months ago

@webbdays I will have to revert this PR, still an issue on the logged page: pageshot of 'Gitpay - Bounties for git issues solved' @ 2024-02-20-1542'57

Please check it and create a new PR with your fixes.

webbdays commented 4 months ago

ok.