worknenjoy / gitpay

Bounties for issues on demand. Be rewarded by learning, using Git workflow and continuous integration
http://gitpay.me
Other
183 stars 164 forks source link

Allow user sort #1075

Closed Precious-Macaulay closed 7 months ago

Precious-Macaulay commented 7 months ago

See #1013

Precious-Macaulay commented 7 months ago

@alexanmtz I have updated the code #1013

alexanmtz commented 7 months ago

@Precious-Macaulay still not seeing any record on the table when we filter on other tabs: pageshot of 'Gitpay - Bounties for git issues solved' @ 2024-02-23-1306'08

And when I tested on the value table along with issues with no bounties, the sorting fails, try to cover this case too.

Can you please check these issues?

Precious-Macaulay commented 7 months ago

Alright i will work on that now

Precious-Macaulay commented 7 months ago

Also @alexanmtz is there away i can populate my local database to test everything before pushing since migration and seeding only creates 3 task and nothing on the other filters tabs

alexanmtz commented 7 months ago

Also @alexanmtz is there away i can populate my local database to test everything before pushing since migration and seeding only creates 3 task and nothing on the other filters tabs

@Precious-Macaulay you can edit the seed to have more tasks, or manually add tasks yourself. You can use my test repository do import issues: https://github.com/alexanmtz/test-repository

We have our front-end tests that you can use to unit test the component, but I guess it would take longer and not required now.

Precious-Macaulay commented 7 months ago

@Precious-Macaulay still not seeing any record on the table when we filter on other tabs: pageshot of 'Gitpay - Bounties for git issues solved' @ 2024-02-23-1306'08

And when I tested on the value table along with issues with no bounties, the sorting fails, try to cover this case too.

Can you please check these issues?

@alexanmtz I have checked all issue

  1. not seeing any record on the table -- it is because there is no record, when i imported an issue i could the record got updated and i could see the issues the actual problem was that the conditional component to render when "no issues " was not returned of which i have fixed.
  2. for this And when I tested on the value table along with issues with no bounties, the sorting fails, try to cover this case too. --- no bounties means the values is 0 so they all maintain their position when sorted since they all have same value.

Additional update is that i handled the null, date and label sorting better to ensure better precision in sorting.

Screenshot (24)

Screenshot (25)

alexanmtz commented 7 months ago

Great @Precious-Macaulay, now it's working great 💯

Let's merge it and thanks for all your effort to get the final result 🥇

Precious-Macaulay commented 7 months ago

You're welcome! I look forward to more contribution.😊