search

worknenjoy / gitpay

Bounties for issues on demand. Be rewarded by learning, using Git workflow and continuous integration
http://gitpay.me
Other
180 stars 160 forks source link

Cannot import issue "Error to update issue" #1083

Closed Zahrun closed 2 months ago

Zahrun commented 3 months ago

Hi there,

I want to fund some issues: https://github.com/mono/mono/issues/14412 and https://github.com/keepassxreboot/keepassxc/issues/2281.

When I click on "import issue" and input any of these two issues url, it shows "Error to update issue".

Zahrun commented 3 months ago

https://github.com/worknenjoy/gitpay/issues/1083 also fails

alexanmtz commented 2 months ago

@Zahrun, we have solved it for now; some of the issues already exist, and we have better feedback now. I think there's a case when the Github API limit is exceeded, and now we have a specific notification for it. We will work to better handle Github API calls or even not depend on them if they're not available in the near future.

Can you test again?

FireShot Capture 001 - Gitpay - Bounties for git issues solved - gitpay me

Zahrun commented 2 months ago

I found under my profile the 3 issues were already created. I deleted the one related to https://github.com/worknenjoy/gitpay/issues/1083 and then created it again. Tried that on mobile the other day and it failed with "actions.task.issues.error.notfound". Maybe deleting and recreating is not supported. Now from laptop I tried again and got "Error to update issue" then refreshed the my profile and it was in the list, created "a few seconds ago". I cleared cookies and site data, reloaded the page, added a different issue https://github.com/pacstall/chaotic-PPR/issues/5, and got again "Error to update issue". Refreshed the profile, and the issue is listed there as actually created.

alexanmtz commented 2 months ago

I found under my profile the 3 issues were already created. I deleted the one related to #1083 and then created it again. Tried that on mobile the other day and it failed with "actions.task.issues.error.notfound". Maybe deleting and recreating is not supported. Now from laptop I tried again and got "Error to update issue" then refreshed the my profile and it was in the list, created "a few seconds ago". I cleared cookies and site data, reloaded the page, added a different issue https://github.com/pacstall/chaotic-PPR/issues/5, and got again "Error to update issue". Refreshed the profile, and the issue is listed there as actually created.

Thanks for reporting, @Zahru, I will work to fix those bugs.

alexanmtz commented 2 months ago

Hey @Zahrun, thanks again for catching all bugs and reporting to us; now I believe these bugs are solved on my last commits: https://github.com/worknenjoy/gitpay/commit/eb1ed4cb9564bd1664690ef11bf5de4e998f1004 https://github.com/worknenjoy/gitpay/commit/05fb7a224501f1eaa441e91b90b4cbbdcc7590e7

Now we verify that the API limit was explicitly exceeded, and the error scenarios with the import process you described were mostly fixed, as the not found and error on update cases.

Let me know if there's any issue; otherwise, we can close this one 🤞

Zahrun commented 2 months ago

Issue created successfully on Gitpay This issue was imported already

It seems to work, very nice, thank you