search

worknenjoy / gitpay

Bounties for issues on demand. Be rewarded by learning, using Git workflow and continuous integration
http://gitpay.me
Other
180 stars 160 forks source link

FIXES: fix lint issues Fixes: #1106

Closed Anshgrover23 closed 2 weeks ago

Anshgrover23 commented 3 weeks ago

fixes: #1038

Description

=> There were over 129 lint issues which i have fixes of type indentation errors, FIXES: fix lint issues Fixes:

/claim #1038

Screenshots

Screenshot (67)

alexanmtz commented 2 weeks ago

Hey @Anshgrover23 , thanks for the PR and great progress on this one, but you still need to set up the right ECMA script version to avoid errors on conditional chaining (variable1?.variable2)

There are still indentation errors to fix and unused variables to get all issues resolved, so please check those.

And we need to figure out why the tests are failing.

alexanmtz commented 2 weeks ago

Hey @Anshgrover23 , we just merged the https://github.com/worknenjoy/gitpay/pull/1107

So we will work from there and I will create a new issue to remove the warnings so I will close this one.

Anshgrover23 commented 2 weeks ago

Ok alex .

On Fri, 21 Jun, 2024, 3:14 pm Alexandre Magno, @.***> wrote:

Hey @Anshgrover23 https://github.com/Anshgrover23 , we just merged the

1107 https://github.com/worknenjoy/gitpay/pull/1107

So we will work from there and I will create a new issue to remove the warnings so I will close this one.

— Reply to this email directly, view it on GitHub https://github.com/worknenjoy/gitpay/pull/1106#issuecomment-2182403407, or unsubscribe https://github.com/notifications/unsubscribe-auth/BIHKKQ7CCGYDFWPHJZDBTJDZIPYW7AVCNFSM6AAAAABJIQHPGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBSGQYDGNBQG4 . You are receiving this because you were mentioned.Message ID: @.***>