search

workouse / availability-notifier-sylius

This plugin provides "send notification when product is available" feature for products out of stock.
MIT License
6 stars 5 forks source link

Make it compatible with symfony 5 #2

Open GalloisLuca opened 3 years ago

GalloisLuca commented 3 years ago

Description
The plugin is not compatible with symfony 5

Example
!! The service "workouse_availability_notifierplugin.controller.availability
!! notifier" has a dependency on a non-existent service "templating". Did you
!! mean one of these: "sylius.templating.helper.convert_money", "sylius.templa
!! ting.helper.adjustment", "sylius.templating.helper.format_money", "sylius.t
!! emplating.helper.currency", "sylius.templating.helper.locale", "sylius.temp
!! lating.helper.inventory", "sylius.templating.helper.product_variants_prices
!! ", "sylius.templating.helper.price", "sylius.templating.helper.variant_reso
!! lver", "sylius.templating.helper.checkout_steps", "sylius.templating.helper
!! .grid", "sylius.templating.helper.bulk_action_grid", "sonata.block.templati
!! ng.helper", "liip_imagine.templating.filter_extension"?

chadyred commented 3 years ago

Any news about it ?

delirehberi commented 3 years ago

there is not active an development on that. we are open for prs.

reyostallenberg commented 2 years ago

Are you still open for PRs on that? I could and would like to help!

delirehberi commented 2 years ago

yes, we would like to review and merge.

reyostallenberg commented 2 years ago

Okay, it'll take some time to work on, but I think that is fine.

I think you should first make a release (tag) on the current state, in order to give people a way to go back, as I think upgrading to current symfony and sylius will make some BC breaks.

On Wed, May 4, 2022 at 12:20 AM Emre YILMAZ @.***> wrote:

yes, we would like to review and merge.

— Reply to this email directly, view it on GitHub https://github.com/workouse/availability-notifier-sylius/issues/2#issuecomment-1116715722, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3JZUQSBISQVBSJYJXFS6TVIGRB7ANCNFSM5A3WC6NQ . You are receiving this because you commented.Message ID: @.***>

delirehberi commented 2 years ago

sure, i will do that tomorrow.

On 4 May 2022 Wed at 01:31 Reyo Stallenberg @.***> wrote:

Okay, it'll take some time to work on, but I think that is fine.

I think you should first make a release (tag) on the current state, in order to give people a way to go back, as I think upgrading to current symfony and sylius will make some BC breaks.

On Wed, May 4, 2022 at 12:20 AM Emre YILMAZ @.***> wrote:

yes, we would like to review and merge.

— Reply to this email directly, view it on GitHub < https://github.com/workouse/availability-notifier-sylius/issues/2#issuecomment-1116715722 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AA3JZUQSBISQVBSJYJXFS6TVIGRB7ANCNFSM5A3WC6NQ

. You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/workouse/availability-notifier-sylius/issues/2#issuecomment-1116722078, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGEI7A73T42HXP3K6CM32TVIGSKXANCNFSM5A3WC6NQ . You are receiving this because you commented.Message ID: @.***>

delirehberi commented 2 years ago

@reyostallenberg tag v1.0.0 created.

chadyred commented 2 years ago

Well done ^^

reyostallenberg commented 2 years ago

@delirehberi do you agree we should only fix for supported versions.

That will mean:

delirehberi commented 2 years ago

yes

On 10 May 2022 Tue at 10:17 Reyo Stallenberg @.***> wrote:

@delirehberi https://github.com/delirehberi do you agree we should only fix for supported versions.

That will mean:

  • PHP 7.4/8.0/8.1
  • Symfony 4.4/5.4/6.0
  • Sylius 1.10/1.11 (as those fit the requirements above)

— Reply to this email directly, view it on GitHub https://github.com/workouse/availability-notifier-sylius/issues/2#issuecomment-1122019292, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGEI7HC7MZR3XUEVZVSWODVJIESFANCNFSM5A3WC6NQ . You are receiving this because you were mentioned.Message ID: @.***>

reyostallenberg commented 2 years ago

Is it possible to get the scrutinizer config in the repo, so I can fix it for current situation? It'll mean the config done in the interface of scrutinizer should be deleted and should be added to the root of the repo in a yaml file

delirehberi commented 2 years ago

I sent a commit to master, is that ok?

reyostallenberg commented 2 years ago

That's okay

costa-jeremy commented 2 years ago

Hello,

It's possible to accept the PR pls ?

Thank you in advance

delirehberi commented 2 years ago

@costa-jeremy it will be merged after pr is completed. still seems work in progress.

reyostallenberg commented 2 years ago

I'll take a look in this shortly. I'm sorry for the delay