search

workshopper / goingnative

A NodeSchool style workshopper for learning how to write native Node.js addons
MIT License
414 stars 54 forks source link

Tolerate node-0.12 #52

Closed hmalphettes closed 9 years ago

hmalphettes commented 9 years ago

Many thanks for the goingnative workshop. I went through it and learnt a lot; all with node-0.12. Here is the patch that makes the exercise 'am i ready?' pass with node-0.12.

I had originally coded the exercise to tolerate iojs versions too... but there is more work to do with node-gyp. Do you guys think we should detect iojs and call pangyp instead? Or do we wait for things to settle?

hmalphettes commented 9 years ago

After some research: for iojs support I will wait on https://github.com/iojs/io.js/pull/493 and https://github.com/TooTallNate/node-gyp/pull/564 to be merged and hopefully nothing else will be needed.