search

workshopper / goingnative

A NodeSchool style workshopper for learning how to write native Node.js addons
MIT License
414 stars 54 forks source link

Status of this project? #86

Closed retrohacker closed 4 years ago

retrohacker commented 4 years ago

Heya folks. I don't really maintain this anymore, haven't worked directly with native modules in well over 4 years.

This project doesn't appear to have any other active maintainers and isn't relevant for modern native module development.

Should we be looking for new maintainers? Should we deprecate this? Thoughts?

ccarruitero commented 4 years ago

Hi @retrohacker ,

I don't have too much experience with native modules, but I would like to help if possible.

As far I can see in node docs, the recommended way to do addons now is to use N-API, but still is possible to use nan or internal v8 too. Also, there is node-addon-api that is the N-API headers-only

I think we should have exercises mainly with N-API, but having exercises using other options (nan, v8, node-addon-api) would be useful too.

At first step, I think we should evaluate if worth it update this workshop or start a new one.

nan version used is 2.2.0 and current version is 2.14.0, so I think shouldn't be too complicated update the exercises. Some dependencies package are unmaintained now (like after and map-async)

So, I suggest to try to update the workshop. What do you think?

retrohacker commented 4 years ago

Thanks for jumping in @ccarruitero!

I'd give you committer rights but I don't have admin rights on this repo. Unless an active maintainer w/ admin rights is around, I think your best bet is to start with a fork of this.

Maybe you can advertise your semi-official fork here on this thread and open a PR to show the improvements?

ccarruitero commented 4 years ago

Sure, I'll be updating the workshop in a fork.

I already have an opened a PR updating some dependencies #84 . So, I think it's ok to use the same PR for next updates.

At first step, I plan to fix the current exercises. And then start adding exercises with N-API.

ccarruitero commented 4 years ago

@retrohacker I fixed the current exercises in #84

Take a look and give any feedback.

I plan to add tests to the repository before start adding exercises with N-API, but could be in another PR so is more easy review changes.

I got commit access to the repository :tada: