lesson 08 publish - Githubissues

workshopper / how-to-npm

A module to teach you how to module.

https://www.npmjs.com/package/how-to-npm

ISC License

1.09k stars 212 forks source link

lesson 08 publish #105

Closed cinyearchan closed 7 years ago

cinyearchan commented 7 years ago

when I type "how-to-npm verify",it print "Looking sharp! A package without a readme and some metadata is like a bunch of JavaScript without instructions or git repo links." why? I've add the "readme" into the "package.json" file "readme": "README.md",

watilde commented 7 years ago

Hello! Did you mean 07-package-niceties? The printed message actually means Sucess, so please don't worry about it. Also, you don't need to put readme filed into your package.json.

https://github.com/workshopper/how-to-npm/blob/master/i18n/en.json#L47

Maybe we can tweak the message to clarify.

watilde commented 7 years ago

Closing as resolved, but if you haven't resolved it yet, please do not hesitate to open it again! Thanks :)