search

workshopper / how-to-npm

A module to teach you how to module.
https://www.npmjs.com/package/how-to-npm
ISC License
1.09k stars 212 forks source link

Update which npm #108

Closed watilde closed 7 years ago

watilde commented 7 years ago

Fixes https://github.com/workshopper/how-to-npm/pull/17, https://github.com/workshopper/how-to-npm/pull/19 and https://github.com/workshopper/how-to-npm/pull/32. Could someone try this patch on Windows?

cc @workshopper/how-to-npm-leads

watilde commented 7 years ago

I'm not sure that I should replace that with just npm.

EmmaRamirez commented 7 years ago

Just finished running through the tutorial on Windows 10 and didn't face any issues that would normally cause it to break due to the quotation marks.

LGTM 👍 😄

watilde commented 7 years ago

@EmmaRamirez Thanks for your review! I will 🐑 it then :)

schellingerhout commented 7 years ago

Just tested on windows 10 with npm installed at "C:\Program Files\nodejs\npm". Seems cause #56 again (See #57 for fix)