search

workshopper / how-to-npm

A module to teach you how to module.
https://www.npmjs.com/package/how-to-npm
ISC License
1.09k stars 212 forks source link

Revert change of pull request #108 #112

Closed schellingerhout closed 7 years ago

schellingerhout commented 7 years ago

For issue #110

This is just a simple rollback of the changes made for release 2.4.1 and essentially rolls back to 2.4.0 state

The issues pull request #108 was supposed to fix were already fixed in pull request #57. This change actually broke the very issues it was supposedly fixing

Mentioning @watilde (issued pull requestion #108), and @EmmaRamirez who reviewed pull request #108

watilde commented 7 years ago

Thanks for the patch! I will ship this since it looks a roll-back as you said.

watilde commented 7 years ago

This patch was shipped as v2.4.2. Thanks again for the issue report, and this patch 😺