search

workshopper / how-to-npm

A module to teach you how to module.
https://www.npmjs.com/package/how-to-npm
ISC License
1.11k stars 219 forks source link

Add basic i18n support for problem text #20

Closed watilde closed 7 years ago

watilde commented 9 years ago

Hi. I added basic i18n support!

Here is updates:

Preview: image

Thanks!

watilde commented 7 years ago

@martinheidegger Yes, it's ok! I've added WIP tag into the title.

watilde commented 7 years ago

@martinheidegger Hey Martin, I've rebased and got rid of translated problem texts to keep the diff more less

watilde commented 7 years ago

Merged https://github.com/watilde/how-to-npm/pull/1

martinheidegger commented 7 years ago

I added another PR to your branch with the missing exercises. Please also run npm test and fix standard formatting ^_^

martinheidegger commented 7 years ago

For extra points:

  1. It might be nice to move to markdown instead of text files?
  2. In /i18n/en.json i put all the exercises in the root node but it would be better if they were one level deeper in exercises
  3. Maybe it would be a good idea to add this to the workshopper definition? (Would need textual updates)
    bg: 'white',
    fg: 'red'
  },
  header: require('workshopper-adventure/default/header'),
  footer: require('workshopper-adventure/default/footer'),
  commands: [{
martinheidegger commented 7 years ago

Do you want to do more changes?

watilde commented 7 years ago

@martinheidegger I've fixed the lint errors, and title names. Then let's do that!

watilde commented 7 years ago

start-a-project/index.js was old, and I've updated it. Verified ✅

watilde commented 7 years ago

@martinheidegger Ok i've tried them all again. Added one fix https://github.com/workshopper/how-to-npm/pull/20/commits/bb111a69c2b6e3bcc183c822b22d8a03690cf1d7, and it worked fine eventually.

martinheidegger commented 7 years ago

@workshopper/core LGTM: ship it?!

watilde commented 7 years ago

Heyy thanks JP and Martin!

a0viedo commented 7 years ago

sorry for getting somewhat late, but great work @watilde @martinheidegger @jpwesselink :tada: