search

workshopper / how-to-npm

A module to teach you how to module.
https://www.npmjs.com/package/how-to-npm
ISC License
1.09k stars 212 forks source link

Support i18n #59

Closed watilde closed 7 years ago

watilde commented 8 years ago

Nowaday, some major workshoppers supported i18n and it's obviously helpful especially for beginners. I would like to get your thoughts on multilingual support.

Technically, current how-to-npm is using the adventure module and it can't support i18n. Also, current way to display question texts is not easy to integrate workshopper-adventure which are used by another workshoppers to support i18n.

e.g.

This PR was too large to review. Let me subdivide the PR to do again realistically:

  1. separate question texts from actual codes
  2. Integrate workshopper-adventure instead of the adventure
  3. Add another language sources
martinheidegger commented 7 years ago

Done I think.

watilde commented 7 years ago

Yes we did it ;)