workshopper / javascripting

Learn JavaScript by adventuring around in the terminal.
http://nodeschool.io
MIT License
2.87k stars 1.04k forks source link

Some text not visible in solarized dark theme #157

Closed ps-aux closed 7 years ago

ps-aux commented 8 years ago

image

In solarized dark theme certain text areas invisible. Maybe it is problem of the theme but this is rather annoying and the theme is quite popular. Possible workaround is with --no-colors.

miklb commented 8 years ago

+1

martinheidegger commented 8 years ago

Note: I reworked the color palette on workshopper-adventure recently to be better readable (particularily on windows). Maybe javascripting needs an updated workshopper-adventure?

miklb commented 8 years ago

Not sure. Attended a nodeschool event in Tampa this evening and wasn't able to read the steps because my terminal uses the Solarized dark theme. Sure I could have switched themes, but didn't feel like fiddling with my terminal. I appreciate the free and open resources, just a heads up.

sethvincent commented 8 years ago

Could y'all try the latest version and see if this is improved for you?

Reinstall with npm:

npm i -g javascripting
ondrejmo commented 8 years ago

I've the same issue and I'm running the latest version, with --no-colors option is everything fine.

rickheere commented 8 years ago

@sethvincent installing the newest version indeed worked for me (Ubuntu). I think this is not longer an issue.

claudiopro commented 8 years ago

This is a real usability problem. I for instance find the yellow text written by webpack unreadable on a white terminal background - yes, I like white terminal background 😄 . Web accessibility has made huge progress, but CLI still has to catch up. True that the user can pick a different theme, but it's a barrier to entry and a hassle.

SomeoneWeird commented 8 years ago

I'm not sure if we can cater to every theme out there, there's always going to be something that conflicts with the styling of a cli program

martinheidegger commented 8 years ago

@ps-aux This is a bug of the solarized color scheme, it would be awesome if you report it! @SomeoneWeird I think it might be fixed in new versions of Workshopper, would you mind to update and redeploy it?

SomeoneWeird commented 8 years ago

Oh? Ok, I'll try get around to it tonight.

esayler commented 8 years ago

Quick iTerm2 Fix

Edit: I haven't tried updating my Solarized Dark iTerm2 colorscheme, which may solve the problem!

screenshot 2016-08-23 18 38 07

  1. Open iTerm2 -> Preferences
  2. After selecting the Profiles tab, click Colors.
  3. On the right-side of the pane, under ANSI Colors, select first box in the Bright column (the Black row)
  4. from the modal's dropdown, select HSB with Brightness Slider.
  5. Drag the slider to the right to make the color brighter.

Should fix the problem without having to adjust the minimum contrast setting.

You can revert to the default Solarized Dark color scheme by selecting it from the Color Presets.. dropdown.

Before:

screenshot 2016-08-23 18 47 05

After:

screenshot 2016-08-23 18 44 53

itzsaga commented 7 years ago

Appears to be fixed.