Switches to cross-spawn to fix issues with Windows shells

workshopper / learn-sass

:school: Learn SASS and SCSS through a workshopper adventure.

MIT License

91 stars 34 forks source link

Closed claudiopro closed 6 years ago

claudiopro commented 7 years ago

Fixes #43, switches to cross-spawn which addresses these issues:

child_process.spawn unable to execute .cmd or .bat commands on Windows
shell: true working only with Node >=v6 (according to cross-spawn; Node docs say it's supported since v4)
Caller has to escape command and arguments when using shell: true

claudiopro commented 7 years ago

Actually it was cherry-picked into v4 LTS and v5 too, see https://github.com/nodejs/node/pull/4598. I'll open a PR to clarify this in cross-spawn.