Change : var to let/const in exercise.js

workshopper / learnyounode

Learn You The Node.js For Much Win! An intro to Node.js via a set of self-guided workshops.

Other

7.24k stars 1.84k forks source link

Change : var to let/const in exercise.js #636

Closed gagandeepp closed 4 years ago

gagandeepp commented 5 years ago

Changed var to let/const in exercise.js file for baby_steps problem

gagandeepp commented 5 years ago

@AnshulMalik Please review this PR and consider this as my contribution to oktoberfest 2018

AnshulMalik commented 5 years ago

Looks like you need to rebase.

On Mon, Oct 1, 2018, 11:31 Gagan Deep notifications@github.com wrote:

@AnshulMalik https://github.com/AnshulMalik Please review this PR and consider this as my contribution to oktoberfest 2018

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/workshopper/learnyounode/pull/636#issuecomment-425797863, or mute the thread https://github.com/notifications/unsubscribe-auth/AHdZvUCwptMbWLUTPrYhniFMIDjcf6MKks5uga_KgaJpZM4XBbKB .

gagandeepp commented 5 years ago

Looks like you need to rebase. … On Mon, Oct 1, 2018, 11:31 Gagan Deep @.***> wrote: @AnshulMalik https://github.com/AnshulMalik Please review this PR and consider this as my contribution to oktoberfest 2018 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#636 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AHdZvUCwptMbWLUTPrYhniFMIDjcf6MKks5uga_KgaJpZM4XBbKB .

Rebase done!. Please review

AnshulMalik commented 5 years ago

I am seeing a lot of commits, looks like you made changes on top of some strange commit.

srl295 commented 5 years ago