workshopper / learnyounode

Learn You The Node.js For Much Win! An intro to Node.js via a set of self-guided workshops.
Other
7.25k stars 1.84k forks source link

Change the module name `map` under exercise HTTP UPPERCASERER #655

Closed shivangg closed 5 years ago

shivangg commented 5 years ago

The through2-map module is stored with the variable name map which introduces confusion as there is already a standard map method in the Array prototype.

image

ccarruitero commented 5 years ago

Hi @shivangg

I don't think this change is necessary.

We just declare a variable named map, and the file is not too big for loose the reference where is declared.

Aside, you can name the variable how you prefer when do the exercise. This is just a solution for reference.

shanmukhateja commented 5 years ago

This issue can be closed as it does not seem to be a real bug.