search

workshopper / learnyounode

Learn You The Node.js For Much Win! An intro to Node.js via a set of self-guided workshops.
Other
7.24k stars 1.84k forks source link

Update problems to use const and let #662

Closed shisama closed 4 years ago

shisama commented 5 years ago

resolve #660

'var' is used in some problem.md files. I think 'let' or 'const' should be used instead of 'var'.

shisama commented 5 years ago

Is there anybody who can review this?

shisama commented 4 years ago

@AnshulMalik Hi, I created this PR 5 months ago. Please review this PR and merge it when you have time. Thanks.

AnshulMalik commented 4 years ago

Hi @shisama, sorry it went unnoticed for so long. Probably because of so many file changes together. I am so sorry for not having a look at it. I think the exercises are already converted by community.

shisama commented 4 years ago

@AnshulMalik Thank you for your reply.

Probably because of so many file changes together.

Is it better for you to divide this PR each exercise? For example, one is PR to update exercises/http_collect, two is exercises/http_file_server, ...

I think the exercises are already converted by community.

OK, I will change the latest code again.

AnshulMalik commented 4 years ago

Yes @shisama one PR per exercise is generally best. Moreover not many exercises are left now :)