search

workshopper / learnyounode

Learn You The Node.js For Much Win! An intro to Node.js via a set of self-guided workshops.
Other
7.25k stars 1.84k forks source link

update wrap fs calls #667

Closed ccarruitero closed 5 years ago

ccarruitero commented 5 years ago

Currently, for verify exercise 4 (my first async io) we are checking for method calls in fs. This will cause that verification fails when use fs.promises or util.promisify.

These changes fix that, by running the checking for fs.promises and util methods as well.

This will fix #651 and #654

AnshulMalik commented 5 years ago

@ccarruitero Tests seems to be failing.

ccarruitero commented 5 years ago

@AnshulMalik that's because the node versions we are using in travis are not compatible with fs.promises. If I well remember, fs.promises was added in node v10. Let's hold until complete #668, and then I update this accordingly.

ccarruitero commented 5 years ago

@AnshulMalik I updated the PR. codeclimate errors aren't related to the changes.

feross commented 5 years ago

@ccarruitero Can you remove the fallback for Node 8? I dropped Node 8 support in this PR: https://github.com/workshopper/learnyounode/pull/677

feross commented 5 years ago

Thanks for the PR @ccarruitero! Released as 4.0.1.