Publish a new major version

workshopper / learnyounode

Learn You The Node.js For Much Win! An intro to Node.js via a set of self-guided workshops.

Other

7.25k stars 1.84k forks source link

Publish a new major version #681

Closed feross closed 5 years ago

feross commented 5 years ago

Waiting for npm publish access from @rvagg to publish a new version with the recent improvements.

No more security warnings in production dependencies!
All code, including in examples uses const and let instead of var (merged the es6 branch and finished the remaining work)
All code, including in markdown, is standard compliant and therefore consistent
Update from standard 11 to 14
Replace code that uses deprecated 'url' module with URL class instead
Outdated offline docs removed; we now include live links to the nodejs.org docs.
BREAKING: Dropped Node 8 support

This should be a major version update.

rvagg commented 5 years ago

@feross please make sure all these changes go in via pull request and at least try to get one or two reviews.

also, I still have a bone to pick with you about [] spacing rules in standard 14 ... but we can fight that out elsewhere

rvagg commented 5 years ago

btw the offline docs were intended to make this possible to do offline, install it and you have everything. Having them out of date is undesirable but it would be nice to consider how we might retain that option.

Flet commented 5 years ago

I bet we could pull the docs from the nodejs.org repo via a release script to ensure they stay up to date. Perhaps we release as-is now and follow up with a PR to do this.

feross commented 5 years ago

@rvagg please make sure all these changes go in via pull request and at least try to get one or two reviews.

Fair enough! Was trying to get this in shape to use it in a class very soon, so apologies for my impatience.

also, I still have a bone to pick with you about [] spacing rules in standard 14 ... but we can fight that out elsewhere

Bring it on! Happy to discuss/reconsider based on your feedback.

btw the offline docs were intended to make this possible to do offline, install it and you have everything. Having them out of date is undesirable but it would be nice to consider how we might retain that option.

@Flet I bet we could pull the docs from the nodejs.org repo via a release script to ensure they stay up to date. Perhaps we release as-is now and follow up with a PR to do this.

Yep, I'd love to bring this back. If someone knows a command to download the docs in a good format for viewing offline, please PR that and I can change all the links back to the offline version with one quick Find-and-Replace.

feross commented 5 years ago

Released 4.0.0.

feross commented 5 years ago

PR to restore the offline docs: https://github.com/workshopper/learnyounode/pull/686