search

workshopper / learnyounode

Learn You The Node.js For Much Win! An intro to Node.js via a set of self-guided workshops.
Other
7.25k stars 1.84k forks source link

Restore offline docs, updated for latest Node #686

Closed feross closed 5 years ago

feross commented 5 years ago

Fixes: #685

Offline bundled docs are now for Node v12. There's also now a script to update them. It uses Monolith (https://github.com/Y2Z/monolith). If someone knows a better way to save and bundle webpages into a single HTML file using a built-in system dependency like wget or curl, or using a Node.js package, please send a PR to improve this.

cc @rvagg @Flet

Flet commented 5 years ago

Ah interesting! I was looking into pulling the api docs right from the node repo.

There are some build scripts in the repo too and it looks like there is one that creates a single HTML file.

Your approach works though! I'm a little worried about brittleness since its pulling a hard-coded list of URLs.

feross commented 5 years ago

If you want to send a PR with a better approach, totally happy to go with that instead. We can even just commit the HTML files without my script to update them if you think it's a bad approach.

feross commented 5 years ago

Released as 4.0.1.