search

workshopper / learnyounode

Learn You The Node.js For Much Win! An intro to Node.js via a set of self-guided workshops.
Other
7.24k stars 1.84k forks source link

Recommend run-parallel instead of async functions #689

Closed feross closed 4 years ago

feross commented 4 years ago

We're not recommending promise versions of node core modules in these exercies yet, so telling newbies to go read about async functions seems like a red herring. I'd rather they use something simple like run-parallel which operates on callbacks for now.

cc @ccarruitero

Flet commented 4 years ago

I wonder if the original intention was to recommend the async package and it was updated to the async language feature by mistake.

I would feel better if it said something like:

Rather than tracking callbacks manually, you may find it more convenient to rely on an npm package such as async or run-parallel. But, for this exercise, do it without any extra packages.

I do prefer your callback management packages, but async is still very popular :)

feross commented 4 years ago

Yeah, this came in through this PR (https://github.com/workshopper/learnyounode/pull/684). I'll update it so it recommends async as well.

feross commented 4 years ago

@Flet – it's updated

feross commented 4 years ago

Released as 4.0.3.