search

workshopper / learnyounode

Learn You The Node.js For Much Win! An intro to Node.js via a set of self-guided workshops.
Other
7.24k stars 1.84k forks source link

remove package-lock.json #692

Closed feross closed 4 years ago

feross commented 4 years ago

Lockfiles are for apps, not modules :)

Flet commented 4 years ago

But isn't this an app? :)

feross commented 4 years ago

But isn't this an app? :)

I agree that it feels like an app... but it's installed like an npm package. When we publish to npm, the package-lock.json file is removed so when the user runs npm install learnyounode -g they're going to get the latest version of packages allowed by package.json.

On the other hand, maintainers working on learnyounode will have package-lock.json present and therefore get different versions than end users.

Flet commented 4 years ago

Ah, didn't know this thanks!