search

workshopper / learnyoureact

Let's learn React.js and server side rendering!
MIT License
536 stars 142 forks source link

Fix execise 04 - proptypes #129

Closed paulodiovani closed 7 years ago

paulodiovani commented 7 years ago

prop-types dependency was missing on exercice 04 instructions and test, leading to errors when running verify.

This pull requests fix that.

Incognito commented 7 years ago

👍 I came here to fix this too, hah!

Choongkyu commented 7 years ago

the command "$ (sudo) npm i -g learnyoureact" still yields me a version of learnyoureact without this correction (ie instructions still show React.PropTypes being used instead of the separate prop-types module). How can I get the version with the correction in this issue ticket?

DusanSacha commented 7 years ago

Hi @zebralight, yes, you are right. Since this repository belongs to workshoper organization, someone from the deployment team has to publish the changes to the npm. I already requested the deploy of the new version, but it is not completed yet.

What you could do is pull the changes from this repository and update your globally installed package manually,

or you could run npm i -g https://github.com/workshopper/learnyoureact.git and this should install the package directly from the repository with all merged changes.

I hope it helps 😉

Cheers and thanks for writing!