workshopper / levelmeup

Level Me Up Scotty! An intro to Node.js databases via a set of self-guided workshops.
Other
271 stars 61 forks source link

levelup docs say to use gte in instead of start #39

Closed Trott closed 7 years ago

Trott commented 9 years ago

https://github.com/rvagg/node-levelup#createReadStream says to use gte instead of start so updated the problem/solution to do that.

rvagg commented 9 years ago

I can't recall off the top of my head if the version of level we are including in levelmeup even has support for the newer properties, did you try it out with the version shipped with levelmeup?

ralphtheninja commented 9 years ago

levelmeup@0.1.10 uses levelup@0.18.6

level@0.18.0 node_modules/level
├── level-packager@0.18.0 (levelup@0.18.6)
└── leveldown@0.10.2 (bindings@1.1.1, nan@0.6.0)

createReadStream() docs for that version, which uses start.

ralphtheninja commented 9 years ago

I guess this PR is in order, but level would have to be updated first imo.

Trott commented 9 years ago

@rvagg I tried the solutions with the version of level that was installed when I installed levelmeup and it seems to work. But the version is as @ralphtheninja says and the documentation there is also as he says (of course). So I'm not sure the problem is between keyboard and chair or if there's something going on that allows gte and lte to work in that version even though it's not documented.

Fortunately, it may not matter as I see he's been kind enough to open a PR to update level-packager which would in turn update blah blah you know how it works a million times better than me so I'll stop now.

martinheidegger commented 7 years ago

Level has been updated in #79, this PR needs a rebase.

Trott commented 7 years ago

OK, rebased and force pushed.

Trott commented 7 years ago

Typo fixed.