add CONTRIBUTING.md - Githubissues

workshopper / org

Organizing the workshopper environment.

9 stars 4 forks source link

Closed sethvincent closed 7 years ago

sethvincent commented 7 years ago

Here's a first draft of a CONTRIBUTING.md file as discussed in #14 & #10.

Feel free to make changes on the contributing branch as needed.

llkats commented 7 years ago

I'm planning on adding/editing some stuff tonight!

sethvincent commented 7 years ago

@martinheidegger ah sorry i missed some things

@llkats 👍 go ahead and push changes to the contributing branch.

llkats commented 7 years ago

Awesome start, @sethvincent! I removed a few more nodejs-specific things and added links to the gitter chatrooms.

A few questions:

Who is in charge of specific workshoppers? I think we should designate maintainers ("stewards"?) in each workshopper's README so it's not overwhelming to maintain a bunch of workshoppers for a few people. We don't have to answer this question right this second, but might be nice to leave a note to fill this in later.
Do we care that much about specifying commit message line character lengths and rebasing? I don't feel as stringent as Node core, so was wondering if people have thoughts on that?

sethvincent commented 7 years ago

Agreed, there should be a list of maintainers in the workshopper readme.

Yeah, it seems like the rebasing and commit message line character lengths can be removed.

llkats commented 7 years ago

@sethvincent @martinheidegger updated! What do you think? As a first draft, I think it's okay for publishing, barring any further edit requests.

sethvincent commented 7 years ago

Cool! Looks good to me.

martinheidegger commented 7 years ago

Fixed NodeFoundation -> Workshopper org in on commit. Else LGTM. Took the honor of merging it ;)