search

workshopper / workshopper-adventure

Not an adventure, not a workshopper - its both!
Other
241 stars 41 forks source link

Fix bug #88

Closed wewark closed 7 years ago

wewark commented 7 years ago

You have completed all the challenges.\nCongratulations!\n now appears instead of error.error.no_uncomplete_left when next is used while all the challenges are completed.

martinheidegger commented 7 years ago

Hello @wewark, thank you for pointing out this issue, however this PR is not good enough to merge yet. As you can see, a few lines below your changes there is a __(...) call which means that at that point translations happen. error.no_uncomplete_left is a perfectly valid translation message as you can see here. The "only" problem is that error.error.no_uncomplete_left is not a valid error - which makes sense. The problem as such should be that this line prefixes the error message with error.. Without the proper time to think about I am not sure what would be the best way to fix this but the fix suggested in this PR seems to address the symptom rather than the root cause.

wewark commented 7 years ago

Hi @martinheidegger, next.message here already had error. prefix, so no need to append it again. I also checked getNext() and it was clear that all its error messages already have error. prefixes. no_uncomplete_left is now properly translated.