search

world-federation-of-advertisers / any-sketch-java

Apache License 2.0
2 stars 0 forks source link

Inconsistent insert function argument naming #12

Open EvgSkv opened 2 years ago

EvgSkv commented 2 years ago

We have two signatures for insert function and the second array is named inconsistently. Is it on purpose? If not, should we rename it?

https://github.com/world-federation-of-advertisers/any-sketch-java/blob/c8ab0f35ba19ff3268d25e2f618bfeda60fa8aa6/src/main/java/org/wfanet/anysketch/AnySketch.java#L116

https://github.com/world-federation-of-advertisers/any-sketch-java/blob/c8ab0f35ba19ff3268d25e2f618bfeda60fa8aa6/src/main/java/org/wfanet/anysketch/AnySketch.java#L132