Jiayupeng/same key aggregator

world-federation-of-advertisers / cardinality_estimation_evaluation_framework

Evaluation framework and methods for estimating cardinalities of groups of sets

Apache License 2.0

22 stars 9 forks source link

Closed jiayu-google closed 4 years ago

jiayu-google commented 4 years ago

Add StandardizedHistogramEstimator which estimates the frequency histogram from any list of ExponentialSameKeyAggregator.

huangxichen1 commented 4 years ago

Hi Jiayu, are you trying to add new commits to this PR? I remember that I have reviewed and approved commits prior to # 1d21b58. A view of comparison shows that you are making a big change to the code: https://github.com/world-federation-of-advertisers/cardinality_estimation_evaluation_framework/compare/1d21b58...bd39760

Would you mind splitting the new commits to another PR, so that you can merge your approved PR to the master and get a smaller new PR for review?

jiayu-google commented 4 years ago

Thanks for reviewing the PR!