world-federation-of-advertisers / cardinality_estimation_evaluation_framework

Evaluation framework and methods for estimating cardinalities of groups of sets
Apache License 2.0
22 stars 9 forks source link

Bug fix for report generator #83

Closed huangxichen1 closed 4 years ago

huangxichen1 commented 4 years ago

Fix for plot link missing due to wrong sketch estimator name.

The bug is from the difference of the sketch_estimator name of the cardinality estimator and the frequency estimator. The previous code will attach -nan to the sketch_estimator name, and that name will not be found in the directory tree. So this PR does the following:

  1. Fix this bug by checking the analysis type.
  2. Add testing for plot file link in the HTML file.