Fix clipping method of VoC.

world-federation-of-advertisers / cardinality_estimation_evaluation_framework

Evaluation framework and methods for estimating cardinalities of groups of sets

Apache License 2.0

21 stars 9 forks source link

Fix clipping method of VoC. #88

Closed jiayu-google closed 3 years ago

jiayu-google commented 3 years ago

Fix a bug in clip_empty_vector_of_count, and add tests.

Note: Sorry that I did not test this part seriously when first writing the clipping method. Other parts of the clipping method had been tested thoroughly and should have no bugs.

jiayu-google commented 3 years ago

Thanks Xichen! Added more tests on intersection.

Note: clipping intersection was implemented using the method evaluate_closeness_to_a_value.