world-federation-of-advertisers / cross-media-measurement

A privacy centric system for cross publisher, cross media ads measurement through secure multiparty computations.
https://halo.wfanet.org/
Apache License 2.0
36 stars 11 forks source link

fix: Remove if check for update time filters when adding shard ID clause in StreamMeasurements #1901

Closed tristanvuong2021 closed 2 weeks ago

tristanvuong2021 commented 3 weeks ago

fix: Remove if check for update time filters when adding shard ID clause in StreamMeasurements

StreamMeasurements always orders results by Update time so the shard ID clause should always be added. Testing revealed that with the if check, setting the after field is required for it to work properly.

wfa-reviewable commented 3 weeks ago

This change is Reviewable