search

world-federation-of-advertisers / cross-media-measurement

A privacy centric system for cross publisher, cross media ads measurement through secure multiparty computations.
https://halo.wfanet.org/
Apache License 2.0
36 stars 11 forks source link

Maximum size for ListRequisitions, ListEventGroups results in response larger than gRPC limit #1915

Closed SanjayVas closed 1 week ago

SanjayVas commented 1 week ago

The default gRPC response size limit is 4 MiB. The current maximum size for both of these methods is 1000.

SanjayVas commented 1 week ago

I ran some calls in the Halo QA environment and found that 100 Requisitions gave a response size of ~627 KiB. This means that we probably want the maximum to be <=500 to be safe. If the previous documentation holds true, it means that ~10 would be the right amount to fit in the optimal response size of 32-64 KiB.

SanjayVas commented 1 week ago

I did a similar test for EventGroups and found that a response with a single EventGroup is ~1774 bytes. We'll likely want to be a bit more conservative there as EventGroups can contain arbitrarily-sized custom metadata.