search

world-federation-of-advertisers / cross-media-measurement

A privacy centric system for cross publisher, cross media ads measurement through secure multiparty computations.
https://halo.wfanet.org/
Apache License 2.0
36 stars 11 forks source link

ci: Add conventional commit PR check #1926

Open mikkokotila opened 1 week ago

mikkokotila commented 1 week ago

Closes #1908

wfa-reviewable commented 1 week ago

This change is Reviewable

mikkokotila commented 1 week ago

Did you evaluate different actions? What signals did you use to determine that of the available actions, that this is of good quality and is well-maintained? Did you consider the alternatives such as wrapping CommitLint with our own action and weigh that against the off-the-shelf options?

No, none of that. I simply tested it in a another repo, and ran through few common scenarios to test it. It is a very simple action, which is very easy to replace if need to. In other words, risk of negative consequences arising from adoption are very low and easy to mitigate in case of arising.

kungfucraig commented 1 day ago

Hey @mikkokotila,

I think the way to go about this would be to write the "RFC", aka one-pager, that outlines one or more options for this. Then circulate that on slack and we can discuss at our eng review meeting in a week and decide on something. I think that will end up being more efficient than designing within the scope of a PR.