worldbank / ESG_gaps_research

See draft publication here: https://worldbank.github.io/ESG_gaps_research/
2 stars 5 forks source link

Update on volatility analysis and mini heatmaps #18

Closed randrescastaneda closed 4 years ago

tonyfujs commented 4 years ago

@randrescastaneda @tgherzog Since those were minor changes, I added them directly to Andres's branch. I did the following:

Will add the new charts on a different branch.

tgherzog commented 4 years ago

@tonyfujs @randrescastaneda I merged both of your PRs but I don't think we're on the same page. The explanation-specific charts that Andres did for section 3 don't have the indicator counts I would expect. For instance, the "no_gap" section shows 4 indicators but I count 12. Explanation A (dropped) shows 9 indicators but I count 15, etc. Note that I'm not using the raw numbers in the database, I'm applying some corrections to business logic, but those corrections result in lower counts for C-G, so that doesn't explain these discrepancies.

The new volatility analysis looks very promising. I'm not quite seeing the high-ranking indicators I would expect, but that could be due to ensuing database updates, so I'll work a bit more on that.