search

worldbank / REaLTabFormer

A suite of auto-regressive and Seq2Seq (sequence-to-sequence) transformer models for tabular and relational synthetic data generation.
https://worldbank.github.io/REaLTabFormer/
MIT License
212 stars 24 forks source link

fix args name mismatch #91

Closed vukasin closed 1 week ago

vukasin commented 1 week ago

Addresses https://github.com/worldbank/REaLTabFormer/issues/90 Passing the arguments by name to ensure proper assignment in the transformers constructor.

avsolatorio commented 1 week ago

Hello @vukasin , Thanks so much for this PR! Could you please update the package's dependency to transformers >= v4.46.0?

Otherwise, this will cause a breaking change for transformers lower than that version; see: https://github.com/huggingface/transformers/blob/c2820c94916e34baf4486accae74760972183a2f/src/transformers/trainer.py#L331

I also suggest removing the devcontainer file currently included in the committed files.

vukasin commented 1 week ago

@avsolatorio. I've made the changes you suggested

avsolatorio commented 1 week ago

Thanks, @vukasin ! Merged! :)

avsolatorio commented 1 week ago

Closes #90