worldbank / dec-python-course

14 stars 5 forks source link

session-2 feedback #18

Closed kbjarkefur closed 1 year ago

weilu commented 2 years ago

Perhaps consider introducing the range function before Task 3?

gauravcusp commented 2 years ago

Good idea! This one can use while loop for now, but I can talk about range.

kbjarkefur commented 2 years ago

In session 1 we call the training "DEC Foundations to Python" and in Session 2 "Python for Data Science". I guess the latter is the full thing and the former is just wat session 1-4 and project 1-2. We should probably call it the same thing :)

luisesanmartin commented 2 years ago

we might consider including a longer explanation of .keys(), .values(), and .items() when explaining for loops of dictionaries

kbjarkefur commented 2 years ago

we might consider including a longer explanation of .keys(), .values(), and .items() when explaining for loops of dictionaries

I also put in https://github.com/worldbank/dec-python-course/issues/14 to cover those methods in Session 1

kbjarkefur commented 2 years ago

Have an example with a dict where some values is not just a single value. For example:

Start with only values and print gdp_dict = {"Argentina" : 389.29, "Belgium" : 521.86} Then do a dict with list as values and print a single value gdp_dict = {"Argentina" : [389.29,'ARG'], "Belgium" : [521.86,'BEL']} Then do a mix and print and show while it is often possible to print but it might not make sense gdp_dict = {"Argentina" : [389.29,'ARG'], "Belgium" : 521.86}

kbjarkefur commented 2 years ago

recursion is cool, but probably too abstract for someone who has known programming for less than 24 hours. I am suggesting to not include it

kbjarkefur commented 2 years ago

In the past when we have received feedback that a training has too much to take in we have applied "MVO". Based on the start-up world's MVP (minimum viable project). But MVO stands for minimum viable objective. I need to apply it to Session 1 as well. What I would do is to separate info into "Must know" and "Good to know" and then drop all good to know. If it is not minimum requirement, then it can go if it already is a lot

kbjarkefur commented 2 years ago

change ## Series code for GDP is "NY.GDP.MKTP.CD" and for Population is "NY.GDP.MKTP.CD". to ## Series code for GDP is "NY.GDP.MKTP.CD" and for Population is "SP.POP.TOTL".

kbjarkefur commented 2 years ago

Task 7 requires understanding of parsing API results but we have not covered APIs. I think it is very difficult to parse the result from the GET request like population = req_pop['source']['data'][0]['value'] if you have no experience of HTTP requests or APIs from before

kbjarkefur commented 2 years ago

When removing too abstract content from this session. Maybe we can add some advice on bug solving. print() intermediate steps etc. In my group people did not first understand the solutions I put on the screen and asked me to explain. I then just added a lot of print() of variables and ran the code again and they were able to follow

gauravcusp commented 1 year ago

Addressed comments in new update. Pull request ready for review.