worldbank / dec-python-course

16 stars 7 forks source link

session1-feedback-feb2023 #40

Closed luisesanmartin closed 11 months ago

luisesanmartin commented 1 year ago
weilu commented 1 year ago

Participant questions:

Wei's feedback:

kbjarkefur commented 1 year ago
  • [x] Reduce time assigned to exercises from 10 to 5 min

Done in 49e770d8f9adb547cecc5b6b451918541e7a4a60

kbjarkefur commented 1 year ago

Methods vs function: IIRC function is generic; methods are functions operated on an object, more often used in the land of OOP. Not necessary to introduce OOP, just a note.

This is what I said right? Maybe in more layman terms, but I will favor "understandable to layman" over "the most correct" in this session.

kbjarkefur commented 1 year ago

Consider cover f-string in place of .format() and make .format() something just to recognize, as increasingly people are using f-strings and .format are more from legacy code.

I have removed the places I use format in the rest of this session. We should show .format() and I like where I currently show it as it is right after we talk about string methods. And right after we do we introduce f-strings. And I think this agrees with what you say. Or is your comment that we should remove .format() from all other sessions as well?

kbjarkefur commented 1 year ago
  • hw = 'hello World' consider giving it a better variable name.

Done in a6564d2e81fe96ae6d2249a9eed61eb643ea2abc

kbjarkefur commented 1 year ago
  • division: consider cover // which will return an integer

Added to table of operators in 2457f8d07827264e9118b424b505e4318ee26e60 but did not add more about it

kbjarkefur commented 1 year ago
  • Exercise 2c passed then failed after the participant finished the rest of the exercises due to variable reuse.

Not sure I follow exactly. But since this exercise is about updating and overwriting variables there is always going to be some order of running the cells that will not pass the assertion. But I think that is also a part of the exercise. To get a felling for how running cells in order or not makes a difference in a notebook context.

kbjarkefur commented 1 year ago

Participant questions:

@kbjarkefur's answer in sub bullets. Let me know if anyone of y'all disagree with my conclusions