search

worldbank / dime-data-handbook

Development Research in Practice: The DIME Analytics Data Handbook. By Kristoffer Bjärkefur, Luíza Cardoso de Andrade, Benjamin Daniels, and Maria Jones
https://worldbank.github.io/dime-data-handbook/
Other
63 stars 26 forks source link

Final review for Chapter 5 #378

Closed bbdaniels closed 4 years ago

bbdaniels commented 4 years ago

@mariaruth to review Chapter 5 language and resources on separate branch. Hopefully this is the last thing before the review version!

mariaruth commented 4 years ago

@bbdaniels should i create the branch for bbd-ch5 or wait until that is merged to develop?

bbdaniels commented 4 years ago

I thought it is merged already? You should be able to create a new branch off develop. Let me know if that's not working.

mariaruth commented 4 years ago

ok, for some reason bbd-ch5 is still showing up for me but content is the same as develop, i'll create from there.

kbjarkefur commented 4 years ago

bbd-ch5 was just this second removed. It might be ok to use that branch, but since other branches has been merged to develop it is much better practice to create a new branch from develop

bbdaniels commented 4 years ago

Yep just went through and cleaned branches that should have been deleted.

kbjarkefur commented 4 years ago

Yep just went through and cleaned branches that should have been deleted.

Ok, I hope that does not create something odd 🤞 as @mariaruth said:

ok, for some reason bbd-ch5 is still showing up for me but content is the same as develop, i'll create from there.

mariaruth commented 4 years ago

addressed in cf99b8226eef4ea38d6f547382f4ed9678d3e53d and ece359f9973cc7b801b683df73ed67600117316c