search

worldbank / dime-data-handbook

Development Research in Practice: The DIME Analytics Data Handbook. By Kristoffer Bjärkefur, Luíza Cardoso de Andrade, Benjamin Daniels, and Maria Jones
https://worldbank.github.io/dime-data-handbook/
Other
64 stars 26 forks source link

Mrj final review ch5 and 7 #399

Closed mariaruth closed 4 years ago

mariaruth commented 4 years ago

Addresses issue #378 and pending parts of #156

bbdaniels commented 4 years ago

@mariaruth @kbjarkefur What branch should this be pointing to? It is at master right now which I assume is NOT right

mariaruth commented 4 years ago

ah sorry, was supposed to be to bbd-review, just fixed

bbdaniels commented 4 years ago

👍🏼 no worries, I just saw "Maria wants to merge 800 commits" and I thought either you did a ton of work or something isn't quite right 😜

kbjarkefur commented 4 years ago

are more edits coming? I only see edits to ch 5. Dont want to review before all edits are uploaded.

mariaruth commented 4 years ago

yup working on the other two chapters now. but most substantial edits are to chapter 5 (not planning to add content elsewhere).

On Fri, Feb 21, 2020 at 1:27 PM Kristoffer Bjärkefur < notifications@github.com> wrote:

are more edits coming? I only see edits to ch 5. Dont want to review before all edits are uploaded.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/worldbank/d4di/pull/399?email_source=notifications&email_token=AFPZKSWUK2E4HTOJYCOVSRTREAMIXA5CNFSM4KZGXVU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMTUMDI#issuecomment-589776397, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFPZKSWSVGJOZG5NVROYQULREAMIXANCNFSM4KZGXVUQ .