worldbank / dime-data-handbook

Development Research in Practice: The DIME Analytics Data Handbook. By Kristoffer Bjärkefur, Luíza Cardoso de Andrade, Benjamin Daniels, and Maria Jones
https://worldbank.github.io/dime-data-handbook/
Other
64 stars 26 forks source link

Word search #409

Closed luizaandrade closed 4 years ago

luizaandrade commented 4 years ago

Just fixing small things. This will probably create conflicts with Ben's new pull requests, though. Solves most of #295, and closes #387, #370, #191, #396

mariaruth commented 4 years ago

Didn’t we agree to change all to “dataset” not “data set”?

Sent from my iPad

On Feb 25, 2020, at 8:36 PM, Luiza Andrade notifications@github.com wrote:

 @luizaandrade commented on this pull request.

In chapters/handling-data.tex:

@@ -100,7 +100,7 @@ \subsection{Research reproducibility} producing these kinds of resources can lead to that as well. Therefore, your code should be written neatly with clear instructions and published openly. It should be easy to read and understand in terms of structure, style, and syntax. -Finally, the corresponding dataset should be openly accessible +Finally, the corresponding data setshould be openly accessible ⬇️ Suggested change -Finally, the corresponding data setshould be openly accessible +Finally, the corresponding data set should be openly accessible — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

luizaandrade commented 4 years ago

that is very possible 🤦‍♀

luizaandrade commented 4 years ago

Ok, I should clearly not be doing this so late, since I'm useless. Will let Kris fix the capital letters, and come back fresh tomorrow.

kbjarkefur commented 4 years ago

I think there was only one case!

kbjarkefur commented 4 years ago

I am ok with merging this now

kbjarkefur commented 4 years ago

Looks like this was committed without your suggestions @mariaruth. Is that ok?

mariaruth commented 4 years ago

better if we could add them, what's the best way to do that?

kbjarkefur commented 4 years ago

restore branch, add them and merge again.

I have restored the branch, and will add those that I think is straightforward and then comment on anyone I am not sure.