search

worldbank / dime-data-handbook

Development Research in Practice: The DIME Analytics Data Handbook. By Kristoffer Bjärkefur, Luíza Cardoso de Andrade, Benjamin Daniels, and Maria Jones
https://worldbank.github.io/dime-data-handbook/
Other
63 stars 26 forks source link

Adding diagrams #494

Closed luizaandrade closed 4 years ago

bbdaniels commented 4 years ago

These are so cool! Just a few general notes on touchup to get them over the finish line. Fonts, colors, and alignment need some tiny detail work; and the verb tense of all the items needs to be brought into agreement. I put specific comments in the markup attached. Let me know if any questions! Figures BBD.pdf

kbjarkefur commented 4 years ago

This PR is starting to have conflicts. we should start this over after mj-review is merged. would it be a lot of work to do this again? If so we can figure this out without starting over

bbdaniels commented 4 years ago

The conflicts that are there are really minor, just changes to wording in two obvious places. However @luizaandrade even though I made comments on the diagrams I am happy to resolve the current versions and the code merged in now, it's a lot easier to update the images with no conflicts in another branch right, plus we can see them render?

bbdaniels commented 4 years ago

In #461 now.