Closed luizaandrade closed 4 years ago
These are so awesome! Very minor things left:
First of all, these diagrams is sooo good!
General comments
Cleaning.png
Analysis.png
publication.png
intro.png
conclusion
Analysis.png
- [x] Polish the results. doesnt it sound as if we try to make the resutls better than they are? Isnt "formatting results" better?
Does "polish and export outputs" sound better?
publication.png
- [x] Why do we make a difference between "License and terms of use" of replication package and "terms of use" for data publication package? Why no license for data?
We typically release terms of use for the data on the microdata catalog, and add a license to the code on GitHub. But if that doesn't seem right, I can change it.
@kbjarkefur are you done working here?
Yes, but someone should review my last commit
Done, although I thought the captions didn't fit and removed them. The intro one is fine, let's see what other people say before fiddling any more with placement. Merging!
Adding diagrams resolves #461. I went back and forth between having them at the end of the chapter or in the beginning, but it seemed to me that it could go well with the final chapter paragraphs mentioned in #482, so I left them at the end. Let me know what you all think.