search

worldbank / dime-data-handbook

Development Research in Practice: The DIME Analytics Data Handbook. By Kristoffer Bjärkefur, Luíza Cardoso de Andrade, Benjamin Daniels, and Maria Jones
https://worldbank.github.io/dime-data-handbook/
Other
63 stars 26 forks source link

Review ch2 #546

Closed kbjarkefur closed 3 years ago

kbjarkefur commented 3 years ago

@luizaandrade , I have marked each commit with the review item number so you can see what feedback it is that I am replying to.

The biggest edit is related to full disk encryption vs. file system encryption. I know how to use both, but got a bit unsure of details when comparing them head to head. I discussed this with a childhood friend who is a networks and systems engineer and was kind to help me talk it over. Took some time to explain our use case of people using personal devices of different platforms, and sharing data insecurely etc., but then we had a good discussion. I want to add him to the acknowledgements. I am interested to see what you think about this new wording.

@bbdaniels , maybe you have opinions on this as well? it is the big edit towards the end of the chapter

kbjarkefur commented 3 years ago

Also, I have not addressed Fede's point about it is good to include version in a do-file as we do talk about that at multiple locations, and she said that she mostly skimmed the book, so she might just have missed it.

kbjarkefur commented 3 years ago

this is ready to be merged