search

worldbank / dime-data-handbook

Development Research in Practice: The DIME Analytics Data Handbook. By Kristoffer Bjärkefur, Luíza Cardoso de Andrade, Benjamin Daniels, and Maria Jones
https://worldbank.github.io/dime-data-handbook/
Other
63 stars 26 forks source link

review ch3 #547

Closed kbjarkefur closed 3 years ago

kbjarkefur commented 3 years ago

All but the two items I have asked about in the DropBox paper for this chapter have been addressed.

mariaruth commented 3 years ago

I will address the point of statistical power. Who's best places to address the other - maybe @luizaandrade ?

mariaruth commented 3 years ago

@bbdaniels it would be great if you can review the last commit [Reviewer comment 3.3.5]

kbjarkefur commented 3 years ago

I have gone over this chapter again. @mariaruth , you can see a summary of my new commits here: https://github.com/worldbank/dime-data-handbook/pull/547/files/fad414274a9cb10f0b1adb4fef91db941f955021..356a498794baf8707b2a76d9b948e404445ea1eb

There will be a ton of conflicts as wiki links were given context in this branch as well. I can spend time fixing that when merging this branch later unless someone else feels up for it!

mariaruth commented 3 years ago

Yeah sorry about that, I got deep into the text and forgot this was already done in another branch that wasn't merged yet. However, i did realize that partway through and stopped so hopefully not too many conflicts. In any case, i'm happy to help resolve.

mariaruth commented 3 years ago

I made some small grammar / wording edits, otherwise all changes look good to me, this is set to merge